From ec4604de3d8f85c4fcbe826336352558e7ecf75c Mon Sep 17 00:00:00 2001 From: Sam Reed Date: Thu, 19 Jan 2012 14:56:18 +0000 Subject: [PATCH] Documentation and whitespace Clearing another w/c --- includes/Feed.php | 1 + maintenance/cleanupUploadStash.php | 8 ++++---- tests/phpunit/includes/UserTest.php | 5 +++++ 3 files changed, 10 insertions(+), 4 deletions(-) diff --git a/includes/Feed.php b/includes/Feed.php index fc637be9f1..351f35729d 100644 --- a/includes/Feed.php +++ b/includes/Feed.php @@ -40,6 +40,7 @@ class FeedItem { * @var Title */ var $title; + var $description; var $url; var $date; diff --git a/maintenance/cleanupUploadStash.php b/maintenance/cleanupUploadStash.php index 10fb4370c9..72118e6393 100644 --- a/maintenance/cleanupUploadStash.php +++ b/maintenance/cleanupUploadStash.php @@ -32,9 +32,9 @@ class UploadStashCleanup extends Maintenance { public function __construct() { parent::__construct(); $this->mDescription = "Clean up abandoned files in temporary uploaded file stash"; - } + } - public function execute() { + public function execute() { $repo = RepoGroup::singleton()->getLocalRepo(); $dbr = $repo->getSlaveDb(); @@ -47,7 +47,7 @@ class UploadStashCleanup extends Maintenance { 'uploadstash', 'us_key', 'us_timestamp < ' . $dbr->addQuotes( $dbr->timestamp( time() - $wgUploadStashMaxAge ) ), - __METHOD__ + __METHOD__, ); if( !is_object( $res ) || $res->numRows() == 0 ) { @@ -58,7 +58,7 @@ class UploadStashCleanup extends Maintenance { // finish the read before starting writes. $keys = array(); - foreach($res as $row) { + foreach( $res as $row ) { array_push( $keys, $row->us_key ); } diff --git a/tests/phpunit/includes/UserTest.php b/tests/phpunit/includes/UserTest.php index 909c0f958e..ef03e83547 100644 --- a/tests/phpunit/includes/UserTest.php +++ b/tests/phpunit/includes/UserTest.php @@ -8,6 +8,10 @@ define( 'NS_UNITTEST_TALK', 5601 ); */ class UserTest extends MediaWikiTestCase { protected $savedGroupPermissions, $savedRevokedPermissions; + + /** + * @var User + */ protected $user; public function setUp() { @@ -90,6 +94,7 @@ class UserTest extends MediaWikiTestCase { $this->assertEquals( $expected, $result, "Groups with permission $right" ); } + public function provideGetGroupsWithPermission() { return array( array( -- 2.20.1